Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spatial_filter.py: use nan-ignoring filter for highpass_gaussian #1030

Merged
merged 1 commit into from
Jun 21, 2023
Merged

spatial_filter.py: use nan-ignoring filter for highpass_gaussian #1030

merged 1 commit into from
Jun 21, 2023

Conversation

scottstanie
Copy link
Contributor

@scottstanie scottstanie commented Jun 20, 2023 •
edited by yunjunz
Loading

referenced here #1018 (comment)

Description of proposed changes

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

yunjunz
yunjunz approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scottstanie.

@yunjunz yunjunz merged commit 4e14bde into insarlab:main Jun 21, 2023
@scottstanie scottstanie deleted the spatial-filter-gaussian-highpass branch June 21, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottstanie @yunjunz