Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nix-prefetch-git to work from within the nix build #351

Closed

Conversation

balsoft
Copy link
Contributor

@balsoft balsoft commented Dec 6, 2019

This PR adds a patched nix-prefetch-git so that uncached dependencies can be downloaded using IFD (with --no-sandbox, of course). Fixes #335

@angerman
Copy link
Collaborator

angerman commented Dec 7, 2019

I’d rather see this as a patch over nix-prefetch-git than an outright new script. That way staying current with upstream as well as making the changes explicit are given.

@balsoft
Copy link
Contributor Author

balsoft commented Dec 7, 2019

Actually, this probably should be fixed in a different way. See https://gitlab.com/tezosagora/agora/commit/330ae03ed732b8843c94be3724dd4637178091b1 , where @yorickvP fixed this problem so that --no-sandbox is not required. I can totally see how we can move this code to haskell.nix (so that cache is generated automatically)

@angerman
Copy link
Collaborator

angerman commented Dec 9, 2019

@balsoft so you are saying we should abandon this PR, in favour of one that generates?

@balsoft
Copy link
Contributor Author

balsoft commented Dec 9, 2019

@angerman it's up to you to decide which is better. I can fix this so that it's a patch instead of whole script replacement, or I can move what @yorickvP has done to here or to nix-tools so that we get sandboxed builds.

@angerman
Copy link
Collaborator

Closed in favour of #358

@angerman angerman closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't download uncached dependencies
2 participants