Merge pull request privacy-scaling-explorations#168 from input-output…

…-hk/dev-fix/address-pr-15 Resolve "Address PR privacy-scaling-explorations#15 issues"
input-output-hk · Mar 18, 2024 · bcae56b · bcae56b
2 parents 12b4b5a + e3b74de
commit bcae56b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/halo2_proofs/src/plonk/poly.rs b/halo2_proofs/src/plonk/poly.rs
@@ -1,4 +1,4 @@
-/// Generic API functionality for how PLONK manages polynomials.
+/// Generic API to encapsulate how a PLONK proof commits to polynomial evaluations.
 use crate::{
     arithmetic::{eval_polynomial, CurveAffine},
     poly::{Coeff, Polynomial},
@@ -14,7 +14,7 @@ pub trait EvaluationCommitment<C: CurveAffine, E: EncodedChallenge<C>> {
         T: TranscriptWrite<C, E>;
 
     /// Extract a set of polynomial evaluations from the transcript.
-    fn decommit<T>(n: usize, transcript: &mut T) -> io::Result<Vec<C::Scalar>>
+    fn read<T>(n: usize, transcript: &mut T) -> io::Result<Vec<C::Scalar>>
     where
         T: TranscriptRead<C, E>;
 }
@@ -36,7 +36,7 @@ impl<C: CurveAffine, E: EncodedChallenge<C>> EvaluationCommitment<C, E> for Dire
         Ok(())
     }
 
-    fn decommit<T>(n: usize, transcript: &mut T) -> io::Result<Vec<C::Scalar>>
+    fn read<T>(n: usize, transcript: &mut T) -> io::Result<Vec<C::Scalar>>
     where
         T: TranscriptRead<C, E>,
     {
@@ -97,7 +97,7 @@ where
         num_evals: usize,
         transcript: &mut T,
     ) -> io::Result<Vec<C::Scalar>> {
-        EvalComm::decommit(num_evals, transcript)
+        EvalComm::read(num_evals, transcript)
     }
 }
 
@@ -142,7 +142,7 @@ mod proptests {
 
             let read_evals = {
                 let mut reader = Blake2bRead::<_, Curve, Challenge255<_>>::init(&proof[..]);
-                let res = DirectCommitment::decommit(NUM_EVALS, &mut reader);
+                let res = DirectCommitment::read(NUM_EVALS, &mut reader);
                 prop_assert!(
                     res.is_ok(),
                     "Reading commitments failed: {res:?}",

diff --git a/halo2_proofs/src/plonk/verifier.rs b/halo2_proofs/src/plonk/verifier.rs
@@ -174,7 +174,7 @@ where
     let instance_evals = if V::QUERY_INSTANCE {
         (0..num_proofs)
             .map(|_| -> Result<Vec<_>, _> {
-                Gen::EvalComm::decommit(vk.cs.instance_queries.len(), transcript)
+                Gen::EvalComm::read(vk.cs.instance_queries.len(), transcript)
             })
             .collect::<Result<Vec<_>, _>>()?
     } else {
@@ -220,7 +220,7 @@ where
 
     let advice_evals = (0..num_proofs)
         .map(|_| -> Result<Vec<_>, _> {
-            Gen::EvalComm::decommit(vk.cs.advice_queries.len(), transcript)
+            Gen::EvalComm::read(vk.cs.advice_queries.len(), transcript)
         })
         .collect::<Result<Vec<_>, _>>()?;