Skip to content

Commit

Permalink
minor
Browse files Browse the repository at this point in the history
  • Loading branch information
@miguel-ambrona
miguel-ambrona committed Apr 23, 2024
1 parent 9d7f948 commit 2e591d5
Showing 1 changed file with 21 additions and 21 deletions.
42 changes: 21 additions & 21 deletions halo2_proofs/src/plonk/keygen.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,19 @@ impl<F: Field> Assignment<F> for Assembly<F> {
A: FnOnce() -> AR,
AR: Into<String>,
{
if !self.usable_rows.contains(&row) {
return Err(Error::not_enough_rows_available(self.k));
}
// if !self.usable_rows.contains(&row) {
// return Err(Error::not_enough_rows_available(self.k));
// }

self.selectors[selector.0][row] = true;

Ok(())
}

fn query_instance(&self, _: Column<Instance>, row: usize) -> Result<Value<F>, Error> {

Check warning on line 90 in halo2_proofs/src/plonk/keygen.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

unused variable: `row` 

warning: unused variable: `row`
  --> halo2_proofs/src/plonk/keygen.rs:90:51
   |
90 |     fn query_instance(&self, _: Column<Instance>, row: usize) -> Result<Value<F>, Error> {
   |                                                   ^^^ help: if this is intentional, prefix it with an underscore: `_row`
   |
   = note: `#[warn(unused_variables)]` on by default

Check warning on line 90 in halo2_proofs/src/plonk/keygen.rs

View workflow job for this annotation

GitHub Actions / Clippy (beta)

unused variable: `row` 

warning: unused variable: `row`
  --> halo2_proofs/src/plonk/keygen.rs:90:51
   |
90 |     fn query_instance(&self, _: Column<Instance>, row: usize) -> Result<Value<F>, Error> {
   |                                                   ^^^ help: if this is intentional, prefix it with an underscore: `_row`
   |
   = note: `#[warn(unused_variables)]` on by default
if !self.usable_rows.contains(&row) {
return Err(Error::not_enough_rows_available(self.k));
}
// if !self.usable_rows.contains(&row) {
// return Err(Error::not_enough_rows_available(self.k));
// }

// There is no instance in this context.
Ok(Value::unknown())
Expand Down Expand Up @@ -126,9 +126,9 @@ impl<F: Field> Assignment<F> for Assembly<F> {
A: FnOnce() -> AR,
AR: Into<String>,
{
if !self.usable_rows.contains(&row) {
return Err(Error::not_enough_rows_available(self.k));
}
// if !self.usable_rows.contains(&row) {
// return Err(Error::not_enough_rows_available(self.k));
// }

*self
.fixed
Expand All @@ -146,9 +146,9 @@ impl<F: Field> Assignment<F> for Assembly<F> {
right_column: Column<Any>,
right_row: usize,
) -> Result<(), Error> {
if !self.usable_rows.contains(&left_row) || !self.usable_rows.contains(&right_row) {
return Err(Error::not_enough_rows_available(self.k));
}
// if !self.usable_rows.contains(&left_row) || !self.usable_rows.contains(&right_row) {
// return Err(Error::not_enough_rows_available(self.k));
// }

self.permutation
.copy(left_column, left_row, right_column, right_row)
Expand All @@ -160,9 +160,9 @@ impl<F: Field> Assignment<F> for Assembly<F> {
from_row: usize,
to: Value<Assigned<F>>,
) -> Result<(), Error> {
if !self.usable_rows.contains(&from_row) {
return Err(Error::not_enough_rows_available(self.k));
}
// if !self.usable_rows.contains(&from_row) {
// return Err(Error::not_enough_rows_available(self.k));
// }

let col = self
.fixed
Expand Down Expand Up @@ -237,9 +237,9 @@ where
circuit.params(),
);

if (params.n() as usize) < cs.minimum_rows() {
return Err(Error::not_enough_rows_available(params.k()));
}
// if (params.n() as usize) < cs.minimum_rows() {
// return Err(Error::not_enough_rows_available(params.k()));
// }

let mut assembly: Assembly<C::Scalar> = Assembly {
k: params.k(),
Expand Down Expand Up @@ -310,9 +310,9 @@ where

let cs = cs;

if (params.n() as usize) < cs.minimum_rows() {
return Err(Error::not_enough_rows_available(params.k()));
}
// if (params.n() as usize) < cs.minimum_rows() {
// return Err(Error::not_enough_rows_available(params.k()));
// }

let mut assembly: Assembly<C::Scalar> = Assembly {
k: params.k(),
Expand Down

0 comments on commit 2e591d5

Please sign in to comment.