Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMC parsing should reject sentences with data valid False #18

Open
peterhinch opened this issue May 29, 2018 · 1 comment
Open

RMC parsing should reject sentences with data valid False #18

peterhinch opened this issue May 29, 2018 · 1 comment

Comments

@peterhinch
Copy link
Contributor

When power is first applied to the MTK3339 chip it emits RMC messages with gps_segments[2] != 'A'. The 'A' value only appears once a satellite fix has been achieved.

Unfortunately those invalid messages can have invalid date/time contents. These can pass subsequent tests, yielding an incorrect timestamp. In my opinion the 'A' value should be checked at the start of parsing, and the sentence rejected if it is invalid.

@Jollyjohn
Copy link

Jollyjohn commented May 13, 2019

@peterhinch Good point. The NEMA standard for RMC is that this character shall be either A=data valid or V=data not valid. I agree that "A" should let the sentence be accepted and all other values cause rejection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants