Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-client: test against a real full node in CI #373

Closed
ebuchman opened this issue Jun 25, 2020 · 3 comments
Closed

light-client: test against a real full node in CI #373

ebuchman opened this issue Jun 25, 2020 · 3 comments
Assignees
Labels
ci Related to continuous integration light-client Issues/features which involve the light client tests
Milestone

Comments

@ebuchman
Copy link
Member

We should run the light node against a real full node in CI per #120 (comment)

We already run the RPC integration tests against a local full node, but we're not running the light node against it.

The first and simplest thing to do is to run the light-node against that full node. Since it will just be a 1 validator blockchain that doesn't change, this will not test much of the light-client functionality, but is more about ensuring the light-node init/config/process is working correctly and can sync with a real full node.

Future iterations could introduce a lot more complexity:

  • talking to multiple full nodes (where one of the full nodes may be faulty or may serve a fork)
  • enabling validator set changes on the chain (this would require other full nodes to actually be set up to be the new validators, even if the light node doesn't talk directly to them!)
  • talking to remote full nodes from a live mainnet/testnet Gaia blockchain

Since there's a lot to do re scoping the more complex set ups, let's start with the simplest for now.

@ebuchman ebuchman added light-client Issues/features which involve the light client tests ci Related to continuous integration labels Jun 25, 2020
@ebuchman ebuchman added this to the Light Node milestone Jun 27, 2020
@xla xla changed the title Light client: test against a real full node in CI light-client: test against a real full node in CI Jun 30, 2020
@liamsi
Copy link
Member

liamsi commented Jul 8, 2020

ref: tendermint/tendermint#5087
Context: when new docker images for tendermint-go are published, it should simplify testing against CI slightly.

@ebuchman
Copy link
Member Author

Hey is this done with #431?

@brapse
Copy link
Contributor

brapse commented Jul 14, 2020

Yeah this is done but made a follow up for the binary initiazation process specifically in #445.

@brapse brapse closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to continuous integration light-client Issues/features which involve the light client tests
Projects
None yet
Development

No branches or pull requests

3 participants