Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move serialization tests into the serialization library #263

Closed
greg-szabo opened this issue May 8, 2020 · 0 comments · Fixed by #274
Closed

Move serialization tests into the serialization library #263

greg-szabo opened this issue May 8, 2020 · 0 comments · Fixed by #274
Assignees

Comments

@greg-szabo
Copy link
Member

greg-szabo commented May 8, 2020

The serializers library is public. It should not be. It's public because tests are in a separate library.

Move the tests into the serializers library and lock it down.

Do this before the next release. We don't want to support a public serializers library.

Relevant discussion: #255 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant