Disclosure log to record ICS3 liveness problems

[adizere]

Closes: #82

Rendered here

Description

Added a markdown file for recording and disclosing all the problems we find in IBC protocols.

---

For contributor use:

• Unit tests written
• Added test to CI if applicable
• Updated CHANGELOG_PENDING.md
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Updated relevant documentation (docs/) and code comments
• Re-reviewed Files changed in the Github PR explorer

[codecov-commenter]

Codecov Report

Merging #83 into master will decrease coverage by 0.3%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master     #83     +/-   ##
========================================
- Coverage    14.4%   14.1%   -0.4%     
========================================
  Files          58      69     +11     
  Lines        2222    3861   +1639     
  Branches      763    1437    +674     
========================================
+ Hits          322     546    +224     
- Misses       1601    2657   +1056     
- Partials      299     658    +359     

Impacted Files	Coverage Δ
relayer/relay/src/config.rs	42.8% <100.0%> (+0.6%)	⬆️
modules/src/ics03_connection/error.rs	33.3% <0.0%> (-9.6%)	⬇️
modules/src/ics04_channel/error.rs	25.0% <0.0%> (-8.4%)	⬇️
modules/src/ics04_channel/msgs.rs	19.1% <0.0%> (-3.2%)	⬇️
modules/src/ics24_host/validate.rs	73.0% <0.0%> (-1.0%)	⬇️
relayer/cli/src/commands/query/connection.rs	24.2% <0.0%> (-1.0%)	⬇️
relayer/cli/src/commands/query/channel.rs	23.7% <0.0%> (-0.9%)	⬇️
relayer/cli/src/commands/query/client.rs	18.6% <0.0%> (-0.8%)	⬇️
modules/src/error.rs	0.0% <0.0%> (ø)
relayer/cli/src/commands.rs	17.6% <0.0%> (ø)
... and 35 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d14599...c3115aa. Read the comment docs.

[ancazamfir]

Thanks Adi. Some comments here but looks good otherwise.

[ancazamfir]

Looks good! A few minor comments. Thanks!

[milosevic]

We should remove reference to a TLA+ spec (for a time being) that generates counter example and just leave description in English with two concurrent relayers stepping at each other foot, and close this PR.

[adizere]

We should remove reference to a TLA+ spec (for a time being) that generates counter example and just leave description in English with two concurrent relayers stepping at each other foot, and close this PR.

This PR is ready for review with a TLA+ spec at the moment. Have a look, and if this proves problematic, then I'll remove the spec and keep just a simple explanation (similar to the description in #61).

[ancazamfir]

Can we can formulate 2 such that we don't talk about h vs h-1? Just mention that in general a proof requires a consensus state at height h and an update of the on-chain client with that may fail.

[adizere]

Can we can formulate 2 such that we don't talk about h vs h-1? Just mention that in general a proof requires a consensus state at height h and an update of the on-chain client with that may fail.

By "2" you mean the concurrency part?
If I understood correctly, the latest commit should be simpler and hopefully achieve this.

[ancazamfir]

Looks good, thanks Adi!