Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the identifiers limits according to updated ics spec #189

Merged
merged 3 commits into from
Jul 31, 2020
Merged

Fixed the identifiers limits according to updated ics spec #189

merged 3 commits into from
Jul 31, 2020

Conversation

andynog
Copy link
Contributor

@andynog andynog commented Jul 31, 2020 •
edited
Loading

Closes: #168

Description

Fixing limits and adding tests.

For contributor use:

  • Unit tests written
  • Added test to CI if applicable
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@andynog andynog requested a review from ancazamfir as a code owner July 31, 2020 16:37
@greg-szabo greg-szabo merged commit acba7ad into master Jul 31, 2020
@greg-szabo greg-szabo deleted the andy/ident-update branch July 31, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-szabo greg-szabo greg-szabo approved these changes

@romac romac Awaiting requested review from romac

@adizere adizere Awaiting requested review from adizere

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identifiers limit update
2 participants
@andynog @greg-szabo