Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CamelCase for types, traits and enum variants #689

Closed
3 of 5 tasks
ancazamfir opened this issue Feb 19, 2021 · 0 comments · Fixed by #690
Closed
3 of 5 tasks

Use CamelCase for types, traits and enum variants #689

ancazamfir opened this issue Feb 19, 2021 · 0 comments · Fixed by #690
Assignees
Labels
O: code-hygiene Objective: cause to improve code hygiene
Milestone

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Feb 19, 2021

Crate

all

Summary

As per title. e.g. cargo +nightly complains with:

error: name `IBCEvent` contains a capitalized acronym
  --> modules/src/events.rs:32:10
   |
32 | pub enum IBCEvent {
   |          ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `IbcEvent`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms

error: name `ICS18Context` contains a capitalized acronym
  --> modules/src/ics18_relayer/context.rs:15:11
   |
15 | pub trait ICS18Context {
   |           ^^^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ics18Context`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms

Problem Definition

Not following Rust naming conventions

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the 03.2021 milestone Feb 19, 2021
@ancazamfir ancazamfir added the O: code-hygiene Objective: cause to improve code hygiene label Feb 19, 2021
@ancazamfir ancazamfir self-assigned this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: code-hygiene Objective: cause to improve code hygiene
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant