Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC TLS support #877

Closed
5 tasks done
allthatjazzleo opened this issue Apr 30, 2021 · 1 comment · Fixed by #1060
Closed
5 tasks done

gRPC TLS support #877

allthatjazzleo opened this issue Apr 30, 2021 · 1 comment · Fixed by #1060
Assignees
@romac @greg-szabo
Labels
I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone
06.2021

Comments

@allthatjazzleo
Copy link
Contributor

allthatjazzleo commented Apr 30, 2021 •
edited by romac
Loading

Crate

relayer

Summary

grpc_addr in config.toml doesn't support tls
so grpc_addr must be in 'http://x.x.x.x:9090' form instead of https

Problem Definition

Proposal

add tonic::transport::ClientTlsConfig support for grpc request?

Acceptance Criteria

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@adizere
Copy link
Member

adizere commented May 5, 2021

Hello,
We'd like to understand how pressing is this issue.
If this gets attention for the release at the end of June (~June 30), would it be ok, or faster than that would be better?

@adizere adizere added this to the 06.2021 milestone May 5, 2021
@adizere adizere added A: question Admin: further information is requested I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product labels May 5, 2021
@ebuchman ebuchman mentioned this issue Jun 1, 2021
Open
5 tasks
@romac romac added O: new-feature Objective: cause to add a new feature or support and removed A: question Admin: further information is requested labels Jun 8, 2021
@romac romac changed the title grpc_addr does not support tls gRPC TLS support Jun 8, 2021
@romac romac mentioned this issue Jun 8, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

@greg-szabo greg-szabo

Labels
I: logic Internal: related to the relaying logic O: new-feature Objective: cause to add a new feature or support O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
None yet
Milestone
06.2021
Development

Successfully merging a pull request may close this issue.

Enable TLS support for gRPC client informalsystems/hermes
4 participants
@romac @adizere @greg-szabo @allthatjazzleo