Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear packets when running hermes start-multi #784

Closed
5 tasks done
ancazamfir opened this issue Mar 30, 2021 · 1 comment · Fixed by #872
Closed
5 tasks done

Clear packets when running hermes start-multi #784

ancazamfir opened this issue Mar 30, 2021 · 1 comment · Fixed by #872
Assignees
@ancazamfir
Labels
E: gravity External: related to Gravity DEX
Milestone
04.2021

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Mar 30, 2021 •
edited by romac
Loading

Crate

relayer

Summary

When hermes start-multi is run pending packets are not currently cleared

Problem Definition

Proposal

Scan all channels over connections configured in config.toml. For each channel, query for pending packets create the workers and generate events (this is already implemented as part of the packet-recv and packet-ack CLIs)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir added this to the 04.2021 milestone Mar 30, 2021
@romac romac self-assigned this Apr 7, 2021
@ancazamfir ancazamfir assigned ancazamfir and unassigned romac Apr 27, 2021
@ancazamfir
Copy link
Collaborator Author

self assigned, it turns out it's 10 extra lines to add to the PR for #786

@ancazamfir ancazamfir mentioned this issue Apr 29, 2021
Merged
5 tasks
@romac romac added the E: gravity External: related to Gravity DEX label Apr 29, 2021
@romac romac closed this as completed in #872 May 4, 2021
This was referenced May 6, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancazamfir ancazamfir

Labels
E: gravity External: related to Gravity DEX
Projects
None yet
Milestone
04.2021
Development

Successfully merging a pull request may close this issue.

Add client workers for active channels, clear packets on start informalsystems/hermes
3 participants
@romac @adizere @ancazamfir