Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tx retry in relayer loop #519

Closed
5 tasks
ancazamfir opened this issue Jan 13, 2021 · 0 comments · Fixed by #547
Closed
5 tasks

Add Tx retry in relayer loop #519

ancazamfir opened this issue Jan 13, 2021 · 0 comments · Fixed by #547
Assignees
Labels
I: logic Internal: related to the relaying logic
Milestone

Comments

@ancazamfir
Copy link
Collaborator

Crate

relayer

Summary

There are some failures in packet Tx that require retries in V0:

  • when the timeout height is close to latest chain height, the relayer still builds a recv_packet (as it should) and it is possible that the chain receives it after the timeout, rejecting therefore the transaction.
  • during testing, if the user issues the packet-send CLI while the relayer processes previously sent packet, it is possible that both the CLI and the relayer loop use the same account sequence. If the packet_send gets through first, the relayer loop Tx will be rejected.

Post V0 other cases will occur.

Proposal

Add retry in relay_from_events() for all failures.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir self-assigned this Jan 18, 2021
@adizere adizere added this to the v0.1.0 milestone Jan 21, 2021
@adizere adizere added the I: logic Internal: related to the relaying logic label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: logic Internal: related to the relaying logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants