perf(inputs/influxdb_listener): benchmark serving writes #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
added
area/influxdb
feat
reimda
reviewed
Nov 19, 2019
reimda
reviewed
Nov 19, 2019
| return listener | ||
| } | ||
|
|
||
| func BenchmarkHTTPListener_serveWrite(b *testing.B) { |
There was a problem hiding this comment.
Is the underscore normal here? It looks kind of out of place.
There was a problem hiding this comment.
Hey @reimda I was following the format of Examples like:
The naming convention to declare examples for the package, a function F, a type T and method M on type T are:
func Example() { ... }
func ExampleF() { ... }
func ExampleT() { ... }
func ExampleT_M() { ... }
reimda
approved these changes
Nov 19, 2019
danielnelson
approved these changes
Nov 26, 2019
|
@reimda Go ahead and merge when you are ready. |
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
…6673) * perf(inputs/influxdb_listener): benchmark serving writes * chore(inputs/influxdb_listener): remove stray comment
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
…6673) * perf(inputs/influxdb_listener): benchmark serving writes * chore(inputs/influxdb_listener): remove stray comment
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
…6673) * perf(inputs/influxdb_listener): benchmark serving writes * chore(inputs/influxdb_listener): remove stray comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Here are some benchmarks for the influxdb listener. I'm hoping these can be guides for performance if there are refactors to do in the plugin.