fix(inputs/nginx_plus_api): swallow 404 error reporting #6015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #5807 Currently, this plugin tries a set of hardcoded paths. Not all paths are enabled in a standard NGINX configuration. This PR skips any API resource paths that do not exist. However, the correct way would be to get the paths from NGINX itself at /api, /api/4, etc rather than have a set of hardcoded paths.
danielnelson
pushed a commit
that referenced
this pull request
Jun 19, 2019
(cherry picked from commit 104db7c)
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5807
Currently, this plugin tries a set of hardcoded paths. Not all paths are enabled in a standard NGINX configuration.
This PR skips any API resource paths that do not exist.
However, the correct way would be to get the paths from NGINX itself at /api, /api/4, etc rather than have a set
of hardcoded paths.
Required for all PRs: