phpfpm plugin: enhance socket stat gathering #538
Conversation
|
thanks much @kureikain 👍 |
| # | ||
| # Note that the unixsocket only works when telegraf run on the same | ||
| # host which is being gather metric because unix socket require local | ||
| # file access. The IP address field is used as a tag, it doesn't mean |
There was a problem hiding this comment.
@kureikain as of Telegraf 0.10.0, we now have the ability to set per-plugin tags (see here: https://github.com/influxdata/telegraf/blob/master/CONFIGURATION.md#input-config-tags)
For this reason, could you just remove the IP address from unix sockets entirely? I still find this confusing, and I think it will confuse more people in the future. I think it's better if people set custom tags using the standard way, rather than inserting it into the unix socket path.
There was a problem hiding this comment.
@sparrc Yes, agree. Let's me remove that.
There was a problem hiding this comment.
@sparrc Removed that tag feature. I also rebase it with master so it's ready to merge if thing looks good.
- If we detect errors when gathering stat via socket, return those error so it canbe appear in Telegraf log - Improve fcgi client, also upgrade it to current version of Go at https://golang.org/src/net/http/fcgi/fcgi.go - Add test for unix socket and fcgi to remotely connect but only as an extra url field. - Allow customization of fpm status path - Document about using of `host` in case `unixsocket` that it isn't used - Documet upgrade for new data layout
|
great, thanks @kureikain |
Ref: #502 #499
so it canbe appear in Telegraf log
Example:
https://golang.org/src/net/http/fcgi/fcgi.go
hostin caseunixsocketthat it isn't usedto remotely connect but only as an extra url field.