Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase varnishstat time allotment. #5130

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Increase varnishstat time allotment. #5130

merged 1 commit into from
Dec 12, 2018

Conversation

lkarsten
Copy link
Contributor

With a large amount of VCLs loaded, varnishstat can take slightly longer to run. This is not a complete fi, but should suffice in 98% of cases.

See varnishcache/varnish-cache#2712 (comment) for some background.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

With a large amount of VCLs loaded, varnishstat can take slightly longer to run. This is not a complete fi, but should suffice in 98% of cases.

See varnishcache/varnish-cache#2712 (comment) for some background.
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If needed, this could be made to be configurable as well. thanks for the contribution

@danielnelson danielnelson added this to the 1.9.2 milestone Dec 11, 2018
@danielnelson danielnelson merged commit d954218 into influxdata:master Dec 12, 2018
danielnelson pushed a commit that referenced this pull request Dec 12, 2018
@lkarsten
Copy link
Contributor Author

Thank you for merging, and for writing/maintaining Telegraf!

@kamsz
Copy link
Contributor

kamsz commented Jan 2, 2019

@glinton I'm experiencing this issue with varnishstat being killed

telegraf[9146]: 2019-01-02T14:37:20Z E! [inputs.varnish]: Error in plugin: error gathering metrics: error running varnishstat: signal: killed

It'd be really helpful to make this configurable.

@glinton
Copy link
Contributor

glinton commented Jan 3, 2019

@kamsz do you mind opening a new feature request for that, thanks

trevorwhitney pushed a commit to trevorwhitney/telegraf that referenced this pull request Feb 14, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
dupondje pushed a commit to dupondje/telegraf that referenced this pull request Apr 22, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants