Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splunk Metrics serializer #4339

Merged
merged 13 commits into from
Sep 11, 2018
Merged

Splunk Metrics serializer #4339

merged 13 commits into from
Sep 11, 2018

Commits on Jun 22, 2018

  1. This serializer formats and outputs the metric data 

    in a format that can be consumed by a Splunk metrics index.

Can be used with any output including file or HTTP.

Please see the docs in README.md
    @ronnocol
    ronnocol committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    135799b View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2018

  1. Cleanup string and byte slices, add hec_routing option 

    These updates cleanup a lot of the handling of the data and allows
to configure if the output should be in a HEC compatible format or
a file/stdout format. Additional documentation files also updated.
    @ronnocol
    ronnocol committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    5dc75f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2018

  1. Add comment on hec_routing flag

    @ronnocol
    ronnocol committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    864ba51 View commit details
    Browse the repository at this point in the history

  2. fixed format; not sure how it broke

    @ronnocol
    ronnocol committed Jun 25, 2018
    Configuration menu
    Copy the full SHA
    49a3c28 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. Drop individual keys instead of whole metrics when the values are not… 

    … numeric.

Some inputs return non-numeric values (e.g. zookeeper returns a version string)
Splunk requires that metrics be numeric, but previously the serializer would drop
the entire input vs. just the offending metric. Now just drop the offencing key/value
and improve error logging:
2018-07-20T02:37:00Z E! Can not parse value: 3.4.12-e5259e437540f349646870ea94dc2658c4e44b3b for key: version
    @ronnocol
    ronnocol committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    b53b2c3 View commit details
    Browse the repository at this point in the history

  2. fmt check fix

    @ronnocol
    ronnocol committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    8c4535f View commit details
    Browse the repository at this point in the history

  3. forgot to update tests

    @ronnocol
    ronnocol committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    30cad33 View commit details
    Browse the repository at this point in the history

  4. Continue past whole metric k/v if the only value is non-parsable.

    @ronnocol
    ronnocol committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    cc29b29 View commit details
    Browse the repository at this point in the history

  5. fmt issues... sorry; one of those days

    @ronnocol
    ronnocol committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    ac56a95 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2018

  1. Change E! to D! since dropping invalid metrics isn't an error 

    Fixup README files as requested in review
    @ronnocol
    ronnocol committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    a3c8374 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2018

  1. Reformat docs as per request. DATA_FORMATS_OUTPUT now just links to s… 

    …plunkmetric README.
    @ronnocol
    ronnocol committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    9c01483 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2018

  1. Fixes requested in PR, also fixed droppping metrics. 

    Tested http input to Splunk 7.1.2 (w/ hec routing)
Verified output of file output.
    @ronnocol
    ronnocol committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    1bb4e2e View commit details
    Browse the repository at this point in the history

  2. gofmt fixes... I really thought make did this

    @ronnocol
    ronnocol committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    67072ba View commit details
    Browse the repository at this point in the history