Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendoring to dep from gdm #4314

Merged
merged 7 commits into from
Jun 19, 2018
Merged

Update vendoring to dep from gdm #4314

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d319c7
Update vendoring to dep from gdm
goller Dec 11, 2017
e7b5daa
Update dependencies within dep
glinton Jun 18, 2018
6f3076c
Convert dependency 'revision' to better version type
glinton Jun 18, 2018
641c905
Resolve dependency issues and update tests
glinton Jun 18, 2018
cc00e08
Cache dependencies in circle
glinton Jun 18, 2018
741fa50
Try resolving 'Filename too long' error
glinton Jun 18, 2018
3e970a6
Cache deps on circle better. Update contributing doc
glinton Jun 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@ jobs:
<<: [ *defaults, *go-1_10 ]
steps:
- checkout
- restore_cache:
key: 'vendor'
- run: 'make deps'
- save_cache:
Copy link
Contributor

@danielnelson danielnelson Jun 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this doesn't cache the new data because the cache is immutable:

Skipping cache generation, cache already exists for key: vendor
Found one created at 2018-06-18 20:19:31 +0000 UTC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd imagine its because nothing changed, but i'll make sure there isn't some update_cache type entry.

name: 'vendored deps'
key: 'vendor'
paths:
- './vendor'
- persist_to_workspace:
root: '/go/src'
paths:
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
/telegraf
/telegraf.exe
/telegraf.gz
vendor/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: /vendor because what if I want to make internal/vendor/stupid_example.go?

100 changes: 0 additions & 100 deletions Godeps
View file
Open in desktop

This file was deleted.

Loading