Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output plugin for Splunk HEC API #4300

Closed
wants to merge 1 commit into from
Closed

output plugin for Splunk HEC API #4300

wants to merge 1 commit into from

Conversation

shrug42
Copy link
Contributor

@shrug42 shrug42 commented Jun 15, 2018 •
edited
Loading

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@shrug42 shrug42 mentioned this pull request Jun 15, 2018
Closed
@danielnelson
Copy link
Contributor

Is this pull request similar to #4185?

@russorat russorat mentioned this pull request Jun 21, 2018
Closed
@phemmer phemmer mentioned this pull request Jun 24, 2018
Merged
@phemmer
Copy link
Contributor

phemmer commented Jun 24, 2018

... and #4339
Right off the bat I can see a few issues with the implementation of this one. But honestly after reviewing 2 other splunk outputs (which have both required significant review), I really don't want to do another. At least not until we pick a single implementation.

@shrug42
Copy link
Contributor Author

shrug42 commented Jun 26, 2018 •
edited
Loading

I am in favor of closing this PR in favor of #4339

Using the http plugin to send the data seems dryer and this way we get serialization for splunk.

@shrug42 shrug42 closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrug42 @danielnelson @phemmer