Add uint support to cratedb output #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixge
approved these changes
May 8, 2018
| return strconv.FormatInt(int64(t), 10), nil | ||
| } else { | ||
| return strconv.FormatInt(MaxInt64, 10), nil | ||
| } |
There was a problem hiding this comment.
So the idea here is to silently truncate large numbers because CrateDB can't store them? I generally prefer to return an error in these situations, but I think there should be at least a comment explaining the reason for this code.
There was a problem hiding this comment.
Yes, this is closely based on the behavior of the InfluxDB output but I can definitely leave a comment.
We could log an error here however in most cases the value would probably be oversized on every interval, so we would want to log only once. We can't return an error from Write() because then Telegraf would retry the metric.
danielnelson
added a commit
that referenced
this pull request
May 8, 2018
(cherry picked from commit b114687)
jvrahav
pushed a commit
to jvrahav/telegraf
that referenced
this pull request
May 9, 2018
arkady-emelyanov
pushed a commit
to arkady-emelyanov/telegraf
that referenced
this pull request
May 18, 2018
leodido
pushed a commit
that referenced
this pull request
May 22, 2018
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 1.6, fields can be int64, uint64, float64, bool, string.
For uint64 values too large to store in CrateDB, we save as the maximum int64 value.
@felixge Can you review?
closes: #4110
Required for all PRs: