Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: fix name_override by name_suffix + example consistency #4100

Merged
merged 1 commit into from
May 4, 2018
Merged

README: fix name_override by name_suffix + example consistency #4100

merged 1 commit into from
May 4, 2018

Conversation

nsteinmetz
Copy link
Contributor

@nsteinmetz nsteinmetz commented May 4, 2018 •
edited
Loading

  • name_suffix will add a suffix to measurement where as name_override will replace measurement name. Here in the sample, it's name_suffix which should have been used
  • fix naming consistency accross settings and examples

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@nsteinmetz
README: fix name_override by name_suffix + example consistency
da0231d 
* name_suffix will add a suffix to measurement where as name_override will replace measurement name. Here in the sample, it's name_suffix which should have been used
* fix naming consistency accross settings and examples
@danielnelson danielnelson added this to the 1.6.2 milestone May 4, 2018
@danielnelson danielnelson added the docs Issues related to Telegraf documentation and configuration descriptions label May 4, 2018
@danielnelson danielnelson merged commit 81620c6 into influxdata:master May 4, 2018
@danielnelson
Copy link
Contributor

Thank you!

danielnelson pushed a commit that referenced this pull request May 4, 2018
@nsteinmetz @danielnelson
Fix name_override example in mysql rreadme (#4100)
81446d8 
(cherry picked from commit 81620c6)
jvrahav pushed a commit to jvrahav/telegraf that referenced this pull request May 9, 2018
@nsteinmetz @jvrahav
Fix name_override example in mysql rreadme (influxdata#4100)
a529da0
arkady-emelyanov pushed a commit to arkady-emelyanov/telegraf that referenced this pull request May 18, 2018
@nsteinmetz @arkady-emelyanov
Fix name_override example in mysql rreadme (influxdata#4100)
8f06f6a
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@nsteinmetz @danielnelson
Fix name_override example in mysql rreadme (#4100)
7e749f8
otherpirate pushed a commit to otherpirate/telegraf that referenced this pull request Mar 15, 2019
@nsteinmetz @otherpirate
Fix name_override example in mysql rreadme (influxdata#4100)
db035ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Issues related to Telegraf documentation and configuration descriptions
Projects
None yet
Milestone
1.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nsteinmetz @danielnelson