added user privilege level setting to IPMI sensors #2397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
suggested changes
Feb 14, 2017
plugins/inputs/ipmi_sensor/ipmi.go
Outdated
| } | ||
|
|
||
| var sampleConfig = ` | ||
| ## optionally specify the path to the ipmitool executable | ||
| # path = "/usr/bin/ipmitool" | ||
| # | ||
| # optionally specify a privilege level, e.g. USER |
There was a problem hiding this comment.
Here I would suggest just copying the comment from the man page:
Force session privilege level. Can be CALLBACK, USER, OPERATOR, ADMINISTRATOR
plugins/inputs/ipmi_sensor/ipmi.go
Outdated
| } | ||
|
|
||
| var sampleConfig = ` | ||
| ## optionally specify the path to the ipmitool executable | ||
| # path = "/usr/bin/ipmitool" | ||
| # | ||
| # optionally specify a privilege level, e.g. USER | ||
| # privilege = "USER" |
There was a problem hiding this comment.
default should be ADMINISTRATOR, as it is for ipmitool in general.
|
@Stefan-Code Can you rebase? (the path fix was merged in a different PR) |
danielnelson
added
the
feat
3 tasks
|
I resolved conflicts and merged this in #3643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #2284
This allows using an unprivileged user for gathering remote IPMI sensor stats.
Also, setting the path for
ipmitoolwas broken because of capitalization?field corresponding to 'path' is not defined in '*ipmi_sensor.Ipmi'I think I fixed that, too.