Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC | Base] Maps #55

Closed
2 of 4 tasks
GantMan opened this issue Apr 14, 2016 · 10 comments
Closed
2 of 4 tasks

[RFC | Base] Maps #55

GantMan opened this issue Apr 14, 2016 · 10 comments

Comments

@GantMan
Copy link
Member

GantMan commented Apr 14, 2016

  • Issue does not already exist
  • Identify exactly what aspect your issue is about
    • ignite base applicattion
    • ignite the cli
    • ignite generated code

Should we put a map screen inside base? Basic maps are easy, but cross platform maps with callouts and a sort of agreed upon best interaction UX, would be nice.

For those of you who've done RN maps, I would like opinions.

For those of you who have not, I'd like your gut reaction.

@skellock
Copy link
Contributor

Yes. Let's dump everything useful in. Kitchen sink style.

v2.0 on the roadmap is to be selective at ignition time.

@jamonholmgren
Copy link
Member

ignition time

I like that @skellock

@jamonholmgren
Copy link
Member

@GantMan I think having kitchen-sink is useful for sure.

@ahmed1490
Copy link

ahmed1490 commented Jun 5, 2016

I have done some map stuff here.. which maybe useful.
https://github.com/ahmed1490/ReactNativeMap
example usage with react-native-maps

@steve21124
Copy link

this react native maps has 954 stars.
https://github.com/lelandrichardson/react-native-maps

@ahmed1490
Copy link

is this closed?

@GantMan
Copy link
Member Author

GantMan commented Jul 5, 2016

I want to keep it open until we're no longer dependent on Steve's branch. I feel we can't forget it in this odd state. Even though it works, it shouldn't sit like this long.

@skellock
Copy link
Contributor

skellock commented Jul 5, 2016

Agreed. I don't want my branch to exist.

More info:

react-native-maps/react-native-maps#331

@ahmed1490
Copy link

ahmed1490 commented Jul 13, 2016

looks like already works with 0.29
react-native-maps/react-native-maps#370
react-native-maps/react-native-maps#390

@GantMan
Copy link
Member Author

GantMan commented Sep 8, 2016

We need to bring maps back in now, it should be good.

@GantMan GantMan added the TODO label Sep 8, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants