Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor library out into separate source file #74

Open
inexorabletash opened this issue Feb 6, 2016 · 3 comments
Open

Factor library out into separate source file #74

inexorabletash opened this issue Feb 6, 2016 · 3 comments

Comments

@inexorabletash
Copy link
Owner

This will require dropping dependencies on variables/functions in the closure (which is probably for the best anyway)

@ianb
Copy link
Contributor

ianb commented Feb 7, 2016

I think it might be a good idea to use Babel before this too, as ES6isms could be useful in this refactoring, specifically arrow functions requiring a few less .bind(this)s. At least I have gotten used to ES6 and miss it here ;)

Of course then there's a build system and all that... maybe Webpack makes sense? Seems like this project fits that well.

@inexorabletash
Copy link
Owner Author

If we start transpiling we can use async/await and the code will be nice and clean again. I'll have to decide if I am willing to commit to that approach yet.

On Feb 7, 2016, at 9:13 AM, Ian Bicking notifications@github.com wrote:

I think it might be a good idea to use Babel before this too, as ES6isms could be useful in this refactoring, specifically arrow functions requiring a few less .bind(this)s. At least I have gotten used to ES6 and miss it here ;)

Of course then there's a build system and all that... maybe Webpack makes sense? Seems like this project fits that well.


Reply to this email directly or view it on GitHub.

@ianb
Copy link
Contributor

ianb commented Feb 7, 2016

So far I've avoiding async/await because it will no longer be entirely clear to me how the transpiled code relates to the original code. But then because I've avoided it I've also no evidence one way or the other ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants