Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/fix CI #279

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Improve/fix CI #279

merged 7 commits into from
Aug 30, 2023

Conversation

cyqsimon
Copy link
Collaborator

See also #277.

This does assume that the path `target/*/build/bandwhich-*/stderr` contains no
spaces, but it should be fine.
@cyqsimon
Copy link
Collaborator Author

cyqsimon commented Aug 26, 2023

All the infrastructure is in place. Awaiting reply from npcap devs. See nmap/npcap#227

@cyqsimon cyqsimon changed the title Improve CI Improve/fix CI Aug 26, 2023
@cyqsimon
Copy link
Collaborator Author

Okay, pcap developers have responded and provided me with the relevant download link, but it does need to be kept private though. @imsnif I have sent you an email with the link and instructions; can you please help set it up using GitHub secrets? Thank you.

@imsnif
Copy link
Owner

imsnif commented Aug 29, 2023

Done!

@cyqsimon
Copy link
Collaborator Author

Retriggered CI

@cyqsimon
Copy link
Collaborator Author

Okay seems like CI is working now (finally). I've noticed there are some seemingly random extra draw events that are causing some tests to fail (sometimes intermittently), but these can be fixed in their own issue. I'll merge this for now.

@cyqsimon cyqsimon merged commit dab58d1 into main Aug 30, 2023
6 of 9 checks passed
@cyqsimon
Copy link
Collaborator Author

Probably should have used squash merge but whatever 😅

@cyqsimon cyqsimon deleted the improve-ci branch August 30, 2023 03:11
@sigmaSd
Copy link
Collaborator

sigmaSd commented Aug 30, 2023

Maybe the windows issues are inpart due to windows report key events kind by default, see crossterm-rs/crossterm#805 crossterm-rs/crossterm#778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants