fix(server): ffmpeg matrices #13461
Merged
fix(server): ffmpeg matrices #13461
+38
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See some comments in #13424 |
lyynd
force-pushed
the
fix-ffmpeg-matrices
branch
from
d802d64
to
f8b346a
Compare
|
Also #13409 for context |
mertalev
reviewed
Oct 16, 2024
mertalev
approved these changes
Oct 16, 2024
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Oct 16, 2024
* Fix ffmpeg matrices * override `getColors` * formatting --------- Co-authored-by: mertalev <101130780+mertalev@users.noreply.github.com>
|
idk if this affects performance or it is the ffmpeg 7 update but I see AV1 encoding slightly slower on my server with 1.118.2 compared to 1.117 just FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time, I'm pretty sure that the values are according to the docs. Didn't test it, but will try at some point. Probably won't be able to test with OpenCL or CUDA.