-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Origin guidance and issuer details #426
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a8f0053
Origin guidance
chris-wood e133f8d
Update origin guidance around blocking behavior
chris-wood be3ec90
Clarify fallback consequences, and make grease behavior for clients
chris-wood 823c433
Update draft-ietf-privacypass-auth-scheme.md
chris-wood aa2dad3
Merge branch 'main' into caw/origin-guidance
chris-wood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "ignoring a token challenge" mean the client treats the 401 as if it didn't have a valid WWW-Authenticate or just that it falls back to whatever the operation is for not having a token available (in the cases where this is different). Maybe this is left to each UA/system, but there might be some edges where issuance protocol failing is distinguishable from not supporting privacy pass at all (though maybe that distinction is fine?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this comment. I would think that ignoring the challenge is the same as a failure to produce a token for any reason, including, e.g., the challenge being invalid. Do you have a specific instance where falling back to default behavior is distinguishable from acting as if the challenge never arrived, and if so, how the text could be updated to reflect that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client ignoring means that no valid auth token is provided — you can't detect on the origin why that is.