Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The next numba headache #662

Open
philippeller opened this issue Mar 24, 2021 · 1 comment
Open

The next numba headache #662

philippeller opened this issue Mar 24, 2021 · 1 comment

Comments

@philippeller
Copy link
Collaborator

NumbaDeprecationWarning: The 'target' keyword argument is deprecated

@thehrh
Copy link
Contributor

thehrh commented Jul 30, 2024

This seems to refer to https://numba.readthedocs.io/en/0.52.0/reference/deprecation.html#deprecation-of-the-target-kwarg, which claims removal of target kwarg from @numba.jit in 0.54.0 (pisa requires >=0.53.0).

Concerning the target kwarg in vectorize and guvectorize, it is still there in the current stable release and is not deprecated either (https://numba.readthedocs.io/en/stable/reference/jit-compilation.html, https://numba.readthedocs.io/en/stable/reference/deprecation.html).

https://github.com/icecube/pisa/blob/master/pisa/utils/numba_tools.py#L107, and here in particular https://github.com/icecube/pisa/blob/master/pisa/utils/numba_tools.py#L139, seems fine. I also can't find any use of jit throughout the code.

Can this issue thus be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants