-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
surprising behavior from Analysis.fit_hypo #661
Comments
Related to #644 |
I am finding the same problem, and with the current Pisa functions for ParamSet, there doesn't seem to be a way to make the current analysis.py code use best fit parameter starting values and set them free at the same time. All one can do if you want to keep the best fit values is fix the parameters in place as described above. A quick and simple way to fix this without messing with Something like:
If this is okay, I would be happy to make a PR for it. |
I come across the same issue while running systematic impact tests with the high stats standard numu disappearance neutrino pipeline. Without setting P.s.: Just for my understanding, when |
After setting a distribution maker's parameters to new
Param
objects,fit_hypo
may discard these parameters before fitting. One example of how this could occur is this:copy.deepcopy(best_fit_params)
Under some conditions, the fit in step 5. will discard the parameters from step 4. This occurs because of the call to
hypo_maker.select_params(full_param_selections)
. I found this behavior very surprising. Whether the fit actually uses parameters fixed before the call tofit_hypo
depends on whether the user modifies parameters in place (which might work) or sets the parameters to newParam
objects (which probably won't work),The text was updated successfully, but these errors were encountered: