New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function called by minimizer is ignoring user-defined prior penalty function #572

Closed

thehrh opened this issue Mar 16, 2020 · 3 comments

Assignees

Contributor

thehrh commented Mar 16, 2020

Compare https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/analysis.py#L1037 to https://github.com/IceCubeOpenSource/pisa/blob/master/pisa/analysis/analysis.py#L849

jllanfranchi assigned ts4051 and philippeller

Contributor

jllanfranchi commented Mar 16, 2020 •

edited

Loading

Looks like this came from @ts4051 and @philippeller here: https://github.com/IceCubeOpenSource/pisa/blame/master/pisa/analysis/analysis.py#L338 so I'm assigning them to this issue

Contributor Author

thehrh commented Mar 16, 2020

The option is uncommented in https://github.com/IceCubeOpenSource/fridge/blob/master/analysis/common/analysis/core/oscillations_analysis.py#L816, though I don't know where else it could have been used

Contributor Author

thehrh commented Aug 3, 2024

I believe this has been solved by now, as evidenced by https://github.com/icecube/pisa/blob/master/pisa/analysis/analysis.py#L2667.

thehrh closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment