You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
originally shows up here: https://github.com/jllanfranchi/pisa/blob/37f168b2d98bd51d8ab90a66c06a80e1a179ef40/pisa/core/events_pi.py#L309-L315
where the np.append was being done, but that will operate on a dict but you can't np.concat dicts. I think whoever wrote this got confused (and confused me) by iterating over keys, values and calling them subkey, subval. Should iterate over key, val and then within each val iterate over subkey, subval and then the arrays live under there and so concatenation can be done.
It doesn't seem to affect anyone in practice, though? Perhaps just assert that the output_data doesn't already contain a given key (describing (anti)neutrino flavour and interaction type) as a quick fix until someone really needs the concatenating logic?
originally shows up here: https://github.com/jllanfranchi/pisa/blob/37f168b2d98bd51d8ab90a66c06a80e1a179ef40/pisa/core/events_pi.py#L309-L315
where the np.append was being done, but that will operate on a dict but you can't np.concat dicts. I think whoever wrote this got confused (and confused me) by iterating over keys, values and calling them subkey, subval. Should iterate over key, val and then within each val iterate over subkey, subval and then the arrays live under there and so concatenation can be done.
In the latest commit, this now shows up at
https://github.com/jllanfranchi/pisa/blob/d356c92b9c96495cb3e0044ca44f277540b76697/pisa/core/events_pi.py#L413-L414
and
https://github.com/jllanfranchi/pisa/blob/d356c92b9c96495cb3e0044ca44f277540b76697/pisa/core/events_pi.py#L431-L434
The text was updated successfully, but these errors were encountered: