Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple_data_loader isn't very simple #503

Open
ts4051 opened this issue Jul 10, 2018 · 0 comments
Open

simple_data_loader isn't very simple #503

ts4051 opened this issue Jul 10, 2018 · 0 comments

Comments

@ts4051
Copy link
Contributor

ts4051 commented Jul 10, 2018

simple_data_loader is becoming increasingly bloated with bespoke behaviour and is no longer really simple.

We should make a dedicated data loader for our IceCube PISA case containing all this functionality, and then make simple_data_loader back into a basic "load a HDF5 file as it is" stage which will be more useful for general cases (e.g. keeping PISA a tool with applicability beyond IceCube).

I am happy to do this when I revisit the events class soon (to better integrated with containers, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants