New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octant checking logic needs cleaning up #493

Closed

thehrh opened this issue Apr 24, 2018 · 1 comment

Contributor

thehrh commented Apr 24, 2018

Issues are:

setting of theta23 start values (both mirroring for 2nd fit + shifting in case of 3rd fit) may violate bounds
the outcome of the 2nd fit (from mirroring into opposite octant) is not treated thoroughly: only the fit octant is checked, and if that's identical to the first the fit is booked as 'alternate fit' (even though it could've in principle resulted in a better fit)

Contributor Author

thehrh commented Jul 31, 2024

Closing for now because of significant code changes in the meantime. Not sure if the combination of https://github.com/icecube/pisa/blob/master/pisa/analysis/analysis.py#L1106 and https://github.com/icecube/pisa/blob/master/pisa/analysis/analysis.py#L1131 still potentially violates theta23 bounds (I didn't find a check at first glance) -> open new issue if necessary.

thehrh closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment