Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrete hypo test is too restrictive #484

Closed
thehrh opened this issue Apr 6, 2018 · 1 comment
Closed

Discrete hypo test is too restrictive #484

thehrh opened this issue Apr 6, 2018 · 1 comment

Comments

@thehrh
Copy link
Contributor

thehrh commented Apr 6, 2018

It currently forces the user to:

  • specify some settings (at least a discrete selection, otherwise there's an exception raised since "there's nothing of substance to be done") for the 2nd hypothesis, even though one might just want to test one hypothesis against (fluctuated, Asimov) data
  • run at least one "fiducial" fit, which makes no sense for the case of a single hypothesis tested (num_fid_trials is forced to be >= 1)

In brief, it seems too tailored to the NMO analysis (and thus probably scares off anyone not familiar with the NMO's intricacies), and is clumsy to work with in simple ensemble fits. It would seem I've been able to relax the above behaviour without introducing any issues into the analysis, so I'm planning to adopt the changes in my general_fitting branch.

@thehrh
Copy link
Contributor Author

thehrh commented Jul 31, 2024

There is no such thing as a discrete hypo test any longer (why does https://github.com/icecube/pisa/blob/master/pisa_tests/test_hypo_testing.sh still exist?)

@thehrh thehrh closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant