Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ratio in map comparison fails if reference hist has zero nominal values and is not a bare numpy array #479

Open
thehrh opened this issue Mar 21, 2018 · 1 comment
Open

Ratio in map comparison fails if reference hist has zero nominal values and is not a bare numpy array #479

thehrh opened this issue Mar 21, 2018 · 1 comment
Labels
bug enhancement
Milestone
PISA 4.2

Comments

@thehrh
Copy link
Contributor

thehrh commented Mar 21, 2018

Setting np.errstate in https://github.com/jllanfranchi/pisa/blob/dev/pisa/core/map.py#L521 doesn't help when hist is an uncertainties.unumpy.uarray (I think this has been an open issue for a long time: lmfit/uncertainties#12). This can be fixed by applying set_errors(None) to the reference map before the division is performed.
@thehrh thehrh mentioned this issue Apr 16, 2018
Open
@thehrh
Copy link
Contributor Author

thehrh commented Apr 20, 2018

This is actually not sufficient, since np.errstate only effective when both maps that are compared have no uncertainties defined (in the case of a zero in the reference map).

@LeanderFischer LeanderFischer added this to the PISA 4.2 milestone Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
PISA 4.2
Development

No branches or pull requests
2 participants
@thehrh @LeanderFischer