Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Group Principal page sections into tabs #33

Open
FloorLamp opened this issue Nov 10, 2021 · 4 comments · May be fixed by #36
Open

Group Principal page sections into tabs #33

FloorLamp opened this issue Nov 10, 2021 · 4 comments · May be fixed by #36

Comments

@FloorLamp
Copy link
Member

FloorLamp commented Nov 10, 2021

Similar to Etherscan's contract page, we should have a tab menu to display each of these components, as we will likely continue to add more components to this page.

@tarek-eg
Copy link
Contributor

tarek-eg commented Nov 10, 2021

If I understood correctly we need to add a sub tab menu to the principal page to be the same as for example Canisters
=> Canisters | Modules | Interfaces
image

@tarek-eg
Copy link
Contributor

@FloorLamp ☝️

@FloorLamp
Copy link
Member Author

Yep, right below the principal details. How about these labels?

  • Genesis Accounts (if principalData?.genesisAccount?.id)
  • Canister Interface (if type === "Canister")
  • Controlled Canisters (if principalData?.canisterCount > 0)
  • Network (if showNodes)
  • CAP Transactions (if is a CAP canister)

@tarek-eg
Copy link
Contributor

Yes that looks fine to me

@tarek-eg tarek-eg linked a pull request Nov 16, 2021 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants