Change surface mesh decimation to vtk based algorithm #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any reason why we used the surface mesh decimation algorithm of open3D?
Cedalion has a huge dependency list already and open3D is somehow annoying to install on MacOS and I also had some issues installing it in a singularity container for running it on the HPC (due to libgomp1). Surface mesh decimation algorithms exist for example also by vtk or in mne (which calls vtk). Both are already dependencies of cedalion.
Mesh quality is the same (both implementations use Quadric Error Metric Decimation).
I also corrected a typo in
src/cedalion/imagereco/forward_model.pyfrom PR#3.