fix(EntityListButton): Fix New Exception button formatting
#727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,7 +169,9 @@ export default class EntityListButtons extends Component<Props, State> { | |||
| bsSize='small' | |||
| data-test-id={`new-${activeComponent}-button`} | |||
| disabled={entities && entities.findIndex(entityIsNew) !== -1} | |||
| onClick={this._onClickNew}> | |||
| onClick={this._onClickNew} | |||
| // Setting the max width to display value so the button does not move to new line | |||
There was a problem hiding this comment.
Add "based on the width of the 'New calendar' button".
There was a problem hiding this comment.
Add also a note that the width of the button text varies depending on the font used.
binh-dam-ibigroup
approved these changes
Oct 6, 2021
miles-grant-ibigroup
approved these changes
Oct 7, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
New Exceptionbutton being moved to new lines based on size. Fixes #725.fix #725
Checklist
devbefore they can be merged tomaster)Description
Changed the New Exception button maxWidth property to avoid the button being moved to a new line, as in issue #725.