-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(EntityListButton): Fix New Exception
button formatting
#727
Conversation
@@ -169,7 +169,9 @@ export default class EntityListButtons extends Component<Props, State> { | |||
bsSize='small' | |||
data-test-id={`new-${activeComponent}-button`} | |||
disabled={entities && entities.findIndex(entityIsNew) !== -1} | |||
onClick={this._onClickNew}> | |||
onClick={this._onClickNew} | |||
// Setting the max width to display value so the button does not move to new line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "based on the width of the 'New calendar' button".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add also a note that the width of the button text varies depending on the font used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two adjustments to the comments, but it should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job finding the fix! I'm a little confused about the sub pixel value, but I trust that there's a good reason
Avoid
New Exception
button being moved to new lines based on size. Fixes #725.fix #725
Checklist
dev
before they can be merged tomaster
)Description
Changed the New Exception button maxWidth property to avoid the button being moved to a new line, as in issue #725.