Fix mastarm lint and resulting linting errors
#425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #425 +/- ##
========================================
+ Coverage 5.29% 5.3% +<.01%
========================================
Files 322 322
Lines 15475 15469 -6
Branches 4674 4674
========================================
Hits 820 820
+ Misses 12503 12497 -6
Partials 2152 2152
Continue to review full report at Codecov.
|
landonreed
approved these changes
Feb 19, 2019
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR fixes the
mastarm lintcommand which was not properly reporting linting errors on various files (#424). The lint command now checks all js files in the__mocks__,__tests__,libandscriptsdirectories. Also, all the offending linting errors that were surfaced are fixed in this PR.