-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeowners, issue template and pr template #411
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #411 +/- ##
========================================
- Coverage 5.3% 5.17% -0.14%
========================================
Files 322 323 +1
Lines 15456 15996 +540
Branches 4655 4953 +298
========================================
+ Hits 820 827 +7
- Misses 12495 12871 +376
- Partials 2141 2298 +157
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice templates, including the explanatory text at the beginning of the issue template. We should use templates like this in all our projects. I might borrow some of the language to update the OTP templates as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just reiterate my previous comment from somewhere else (datatools-server or gtfs-lib) that we may not want to require that a PR to master necessarily improve code coverage.
I changed the wording for code coverage. Acceptable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @evansiroky. I like the spirit of that wording change.
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Checklist
dev
before they can be merged tomaster
)Description
This PR adds codeowners, an issue template and a PR tempalte in order to resolve #410.