Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners, issue template and pr template #411

Merged
merged 5 commits into from
Feb 19, 2019
Merged

Conversation

evansiroky
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Referenced all applicable issues this PR seeks to resolve
  • All tests and CI builds passing

Description

This PR adds codeowners, an issue template and a PR tempalte in order to resolve #410.

@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #411 into dev will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             dev    #411      +/-   ##
========================================
- Coverage    5.3%   5.17%   -0.14%     
========================================
  Files        322     323       +1     
  Lines      15456   15996     +540     
  Branches    4655    4953     +298     
========================================
+ Hits         820     827       +7     
- Misses     12495   12871     +376     
- Partials    2141    2298     +157
Impacted Files Coverage Δ
lib/manager/actions/status.js 13.6% <0%> (-4.1%) ⬇️
lib/gtfs/util/graphql.js 33.8% <0%> (-1.5%) ⬇️
lib/gtfs/util/index.js 4.05% <0%> (-0.27%) ⬇️
lib/alerts/reducers/alerts.js 11.84% <0%> (-0.16%) ⬇️
lib/alerts/components/ModeSelector.js 0% <0%> (ø) ⬆️
lib/gtfsplus/components/GtfsPlusField.js 0% <0%> (ø) ⬆️
lib/editor/components/EntityList.js 0% <0%> (ø) ⬆️
lib/public/components/PublicHeader.js 0% <0%> (ø) ⬆️
lib/gtfs/components/gtfs-search.js 0% <0%> (ø) ⬆️
lib/gtfs/components/GtfsMap.js 0% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac5a6a...f4f1414. Read the comment docs.

Copy link
Contributor

@abyrd abyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice templates, including the explanatory text at the beginning of the issue template. We should use templates like this in all our projects. I might borrow some of the language to update the OTP templates as well.

Copy link
Contributor

@landonreed landonreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just reiterate my previous comment from somewhere else (datatools-server or gtfs-lib) that we may not want to require that a PR to master necessarily improve code coverage.

@landonreed landonreed assigned evansiroky and unassigned landonreed Feb 19, 2019
@evansiroky
Copy link
Contributor Author

I changed the wording for code coverage. Acceptable?

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Feb 19, 2019
Copy link
Contributor

@landonreed landonreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evansiroky. I like the spirit of that wording change.

@landonreed landonreed merged commit 0f10fa2 into dev Feb 19, 2019
@landonreed landonreed deleted the github-settings branch February 19, 2019 23:33
@landonreed
Copy link
Contributor

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should have issue and pr templates
4 participants