Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unintended side effects from using turf-line-slice #119

Closed
landonreed opened this issue Dec 7, 2018 · 2 comments
Closed

Unintended side effects from using turf-line-slice #119

landonreed opened this issue Dec 7, 2018 · 2 comments
Labels
imported released

Comments

@landonreed
Copy link
Contributor

Issue by evansiroky
Wednesday Aug 02, 2017 at 17:45 GMT
Originally opened as catalogueglobal#13

The turf-line-slice package extracts a section of a linestring between two points. It does this by finding the geometrically closest position on the linestring to a start and end point respectively. Using this approximation can have a bad effect in cases where a line interects itself or for when start or end points are used that are closer to a unintended section of a linestring. A different algorithm should be employed in place of the use of this package.
@landonreed
Copy link
Contributor Author

Comment by landonreed
Tuesday Nov 13, 2018 at 18:01 GMT

@evansiroky, should this be closed? I think #14 was intended to fix this but maybe no commit referenced it.

@landonreed
Copy link
Contributor Author

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
imported released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@landonreed