Auto deploy feed version

[br648]

Checklist

• Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
• Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
• The description lists all applicable issues this PR seeks to resolve
• The description lists any configuration setting(s) that differ from the default settings
• All tests and CI builds passing

Description

Auto deploy logic updated to match: https://docs.google.com/document/d/1-ktTBm2phT_7rIVQgk5XbyxT7VtjQnpll4hIyDP8AhQ/edit#heading=h.5s90wltgha1q

[landonreed]

A few minor things. I still need to review the tests a bit more. Also, we need to get the GH actions PR (#360) reviewed and merged into dev before this one now that Travis CI is turned off and we're not getting CI pass/fail indications.

[codecov-io]

Codecov Report

Merging #361 (238d4c6) into dev (11a5597) will increase coverage by 1.86%.
The diff coverage is 59.18%.

@@             Coverage Diff              @@
##                dev     #361      +/-   ##
============================================
+ Coverage     26.61%   28.48%   +1.86%     
- Complexity      655      723      +68     
============================================
  Files           179      180       +1     
  Lines          9227     9356     +129     
  Branches       1249     1284      +35     
============================================
+ Hits           2456     2665     +209     
+ Misses         6533     6405     -128     
- Partials        238      286      +48     

Flag	Coverage Δ	Complexity Δ
unit_tests	28.48% <59.18%> (+1.86%)	0.00 <27.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
...om/conveyal/datatools/editor/datastore/FeedTx.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...ools/manager/controllers/api/StatusController.java	33.92% <ø> (+12.50%)	9.00 <0.00> (+4.00)
...com/conveyal/datatools/manager/jobs/DeployJob.java	24.11% <0.00%> (+5.79%)	33.00 <0.00> (+9.00)
...conveyal/datatools/manager/jobs/MergeFeedsJob.java	78.94% <0.00%> (-0.19%)	120.00 <0.00> (ø)
...l/datatools/manager/jobs/ProcessSingleFeedJob.java	84.28% <0.00%> (+0.22%)	20.00 <0.00> (+1.00)
...com/conveyal/datatools/manager/models/Project.java	66.66% <ø> (ø)	6.00 <0.00> (ø)
.../manager/controllers/api/DeploymentController.java	11.57% <35.00%> (+2.52%)	3.00 <1.00> (+1.00)
.../conveyal/datatools/manager/models/Deployment.java	15.54% <47.05%> (+11.45%)	19.00 <5.00> (+15.00)
...conveyal/datatools/manager/jobs/AutoDeployJob.java	64.38% <64.38%> (ø)	12.00 <12.00> (?)
...nveyal/datatools/common/status/MonitorableJob.java	82.11% <75.00%> (-0.54%)	12.00 <0.00> (ø)
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a5597...238d4c6. Read the comment docs.

[landonreed]

@br648, I just made some changes to provide access to MonitorableJob#subJobs and updated the auto deploy test class to make use of that (though the assertions have not been updated yet). Once you're able to update the assertions, I think we can assign to @binh-dam-ibigroup for review.

[landonreed]

OK, I think this is ready for @binh-dam-ibigroup. @br648, feel free to take another look at my latest tweaks as well.

[br648]

@evansiroky, thanks for the update. I have now merged this into the auto deploy branch.

[evansiroky]

I think this is functionally complete. We still need to make a UI that will go with these changes, so let's not merge to dev just yet, or if we do, we'll want to make sure we somewhat thoroughly try out this AutoDeploy stuff out before deploying to a production environment.

[evansiroky]

Something that just came to mind is that this could result in an endless loop of deployments. So if a deployment is initialized, then the deploy job finishes successfully there would be no stopping point within either this job or the AutoDeploy job until an error occurs.

[binh-dam-ibigroup]

LGTM, just one minor formatting suggestion.