Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include type defs. in esm build #971

Closed
aarondrabeck opened this issue Jul 27, 2020 · 2 comments · Fixed by #985
Closed

Include type defs. in esm build #971

aarondrabeck opened this issue Jul 27, 2020 · 2 comments · Fixed by #985
Labels
enhancement New feature or request good first issue Good for newcomers released

Comments

@aarondrabeck
Copy link

Describe the bug
Types are not included in the esm folder so they are not detected when using standard imports.

import dayjs from 'dayjs/esm';
@aarondrabeck aarondrabeck changed the title Include types in esm build Include type defs. in esm build Jul 27, 2020
@iamkun iamkun added the enhancement New feature or request label Jul 28, 2020
@iamkun
Copy link
Owner

iamkun commented Jul 28, 2020

This would be a nice enhancement

@iamkun iamkun added the good first issue Good for newcomers label Jul 28, 2020
@stoicsleuth stoicsleuth mentioned this issue Aug 5, 2020
Merged
@iamkun
Copy link
Owner

iamkun commented Aug 10, 2020

🎉 This issue has been resolved in version 1.8.33 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added typedefs in esm build stoicsleuth/dayjs
2 participants
@aarondrabeck @iamkun