Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isToday, isTomorrow, isYesterday plugins #857

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Conversation

epszaw
Copy link
Contributor

@epszaw epszaw commented Apr 7, 2020

Update:

https://day.js.org/docs/en/plugin/is-today
https://day.js.org/docs/en/plugin/is-tomorrow
https://day.js.org/docs/en/plugin/is-yesterday


As requested for #299. But I don't know what I should do with 7e2dcc0. @iamkun what do you think? May be just drop it from my branch?

close #299

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #857 into dev will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               dev      #857    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          160       164     +4     
  Lines         1205      1318   +113     
  Branches       248       272    +24     
==========================================
+ Hits          1205      1318   +113     
Impacted Files Coverage Δ
src/plugin/isToday/index.js 100.00% <100.00%> (ø)
src/plugin/isTomorrow/index.js 100.00% <100.00%> (ø)
src/plugin/isYesterday/index.js 100.00% <100.00%> (ø)
src/plugin/duration/index.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39fb96...bdf6a54. Read the comment docs.

@iamkun
Copy link
Owner

iamkun commented Apr 7, 2020

why a CHANGELOG.md in git diff ?

@epszaw
Copy link
Contributor Author

epszaw commented Apr 7, 2020

I don't know, because just made rebase from actual master. I can drop another commit from PR and leave only need with plugins

@iamkun
Copy link
Owner

iamkun commented Apr 7, 2020

That will be nice, thanks.

@epszaw
Copy link
Contributor Author

epszaw commented Apr 7, 2020

@iamkun all done

src/plugin/isToday/index.js Outdated Show resolved Hide resolved
@iamkun iamkun merged commit fc08ab6 into iamkun:dev Apr 8, 2020
iamkun pushed a commit that referenced this pull request Apr 10, 2020
## [1.8.24](v1.8.23...v1.8.24) (2020-04-10)

### Bug Fixes

* Add config option to RelativeTime plugin ([#851](#851)) ([bd24034](bd24034))
* add Duration plugin ([#858](#858)) ([d568273](d568273))
* Add en-in, en-tt locales ([#855](#855)) ([c39fb96](c39fb96))
* add isToday, isTomorrow, isYesterday plugins ([#857](#857)) ([fc08ab6](fc08ab6))
* Add option callback to Calendar plugin ([#839](#839)) ([b25be90](b25be90))
* Fix monthsShort for locale fr ([#862](#862)) ([d2de9a0](d2de9a0))
* Update Breton locale (br) meridiem config ([#856](#856)) ([a2a6672](a2a6672))
* Update Ukrainian (uk) locale relative time ([#842](#842)) ([578bc1a](578bc1a))
@iamkun
Copy link
Owner

iamkun commented Apr 10, 2020

🎉 This PR is included in version 1.8.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.24](iamkun/dayjs@v1.8.23...v1.8.24) (2020-04-10)

### Bug Fixes

* Add config option to RelativeTime plugin ([#851](iamkun/dayjs#851)) ([bd24034](iamkun/dayjs@bd24034))
* add Duration plugin ([#858](iamkun/dayjs#858)) ([d568273](iamkun/dayjs@d568273))
* Add en-in, en-tt locales ([#855](iamkun/dayjs#855)) ([c39fb96](iamkun/dayjs@c39fb96))
* add isToday, isTomorrow, isYesterday plugins ([#857](iamkun/dayjs#857)) ([fc08ab6](iamkun/dayjs@fc08ab6))
* Add option callback to Calendar plugin ([#839](iamkun/dayjs#839)) ([b25be90](iamkun/dayjs@b25be90))
* Fix monthsShort for locale fr ([#862](iamkun/dayjs#862)) ([d2de9a0](iamkun/dayjs@d2de9a0))
* Update Breton locale (br) meridiem config ([#856](iamkun/dayjs#856)) ([a2a6672](iamkun/dayjs@a2a6672))
* Update Ukrainian (uk) locale relative time ([#842](iamkun/dayjs#842)) ([578bc1a](iamkun/dayjs@578bc1a))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.24](iamkun/dayjs@v1.8.23...v1.8.24) (2020-04-10)

### Bug Fixes

* Add config option to RelativeTime plugin ([#851](iamkun/dayjs#851)) ([bd24034](iamkun/dayjs@bd24034))
* add Duration plugin ([#858](iamkun/dayjs#858)) ([d568273](iamkun/dayjs@d568273))
* Add en-in, en-tt locales ([#855](iamkun/dayjs#855)) ([c39fb96](iamkun/dayjs@c39fb96))
* add isToday, isTomorrow, isYesterday plugins ([#857](iamkun/dayjs#857)) ([fc08ab6](iamkun/dayjs@fc08ab6))
* Add option callback to Calendar plugin ([#839](iamkun/dayjs#839)) ([b25be90](iamkun/dayjs@b25be90))
* Fix monthsShort for locale fr ([#862](iamkun/dayjs#862)) ([d2de9a0](iamkun/dayjs@d2de9a0))
* Update Breton locale (br) meridiem config ([#856](iamkun/dayjs#856)) ([a2a6672](iamkun/dayjs@a2a6672))
* Update Ukrainian (uk) locale relative time ([#842](iamkun/dayjs#842)) ([578bc1a](iamkun/dayjs@578bc1a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isToday, isTomorrow, isYesterday
2 participants