Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle locale in WeekOfYear plugin #658

Merged
merged 2 commits into from
Aug 19, 2019
Merged

fix: Handle locale in WeekOfYear plugin #658

merged 2 commits into from
Aug 19, 2019

Conversation

g1eny0ung
Copy link
Contributor

@g1eny0ung g1eny0ung commented Aug 13, 2019

Handle locale in weekOfYear plugin

close #650

 Handle locale in weekOfYear plugin
@codecov-io
Copy link

codecov-io commented Aug 13, 2019

Codecov Report

Merging #658 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #658      +/-   ##
==========================================
+ Coverage   99.89%   99.89%   +<.01%     
==========================================
  Files         154      154              
  Lines         989      990       +1     
  Branches      148      149       +1     
==========================================
+ Hits          988      989       +1     
  Misses          1        1
Impacted Files Coverage Δ
src/plugin/weekOfYear/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e70b4...fda8fea. Read the comment docs.

// eslint-disable-next-line prefer-destructuring
weekStart = locale.weekStart
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const weekStart = this.$locale().weekStart || 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Already update.

@iamkun iamkun merged commit 0e45b0a into iamkun:dev Aug 19, 2019
@iamkun iamkun changed the title Fixes issue#650 fix: Handle locale in WeekOfYear plugin Aug 26, 2019
iamkun pushed a commit that referenced this pull request Aug 27, 2019
## [1.8.16](v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](a385d5c))
* Handle locale in WeekOfYear plugin ([#658](#658)) ([0e45b0a](0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](#645)) ([95e70b4](95e70b4))
* Return null in toJSON if not valid ([#633](#633)) ([19affc8](19affc8))
* Update Danish (da) locale ([#626](#626)) ([ac2ec77](ac2ec77))
* Update Korean locale meridiem ([#642](#642)) ([b457146](b457146))
* update Occitan locale Catalan locale ([#630](#630)) ([fef135e](fef135e))
* update pt-br locale ([#628](#628)) ([ccf596d](ccf596d))
* Update weekdaysShort to some locale files ([#643](#643)) ([cc1f15f](cc1f15f))
@iamkun
Copy link
Owner

iamkun commented Aug 27, 2019

🎉 This PR is included in version 1.8.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c))
* Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4))
* Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8))
* Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77))
* Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146))
* update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e))
* update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d))
* Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.16](iamkun/dayjs@v1.8.15...v1.8.16) (2019-08-27)

### Bug Fixes

* Fix relativeTime Plugin .FromNow() result error in UTC mode ([a385d5c](iamkun/dayjs@a385d5c))
* Handle locale in WeekOfYear plugin ([#658](iamkun/dayjs#658)) ([0e45b0a](iamkun/dayjs@0e45b0a))
* LocaleData plugin returns all months and weekdays data when pas no argument ([#645](iamkun/dayjs#645)) ([95e70b4](iamkun/dayjs@95e70b4))
* Return null in toJSON if not valid ([#633](iamkun/dayjs#633)) ([19affc8](iamkun/dayjs@19affc8))
* Update Danish (da) locale ([#626](iamkun/dayjs#626)) ([ac2ec77](iamkun/dayjs@ac2ec77))
* Update Korean locale meridiem ([#642](iamkun/dayjs#642)) ([b457146](iamkun/dayjs@b457146))
* update Occitan locale Catalan locale ([#630](iamkun/dayjs#630)) ([fef135e](iamkun/dayjs@fef135e))
* update pt-br locale ([#628](iamkun/dayjs#628)) ([ccf596d](iamkun/dayjs@ccf596d))
* Update weekdaysShort to some locale files ([#643](iamkun/dayjs#643)) ([cc1f15f](iamkun/dayjs@cc1f15f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expect(dayjs('2019-07-28').week()).toBe(30)
3 participants