Add locales for relativeTime and formats from momentjs

[aadityataparia]

Inspired from #541

This PR imports relativeTime and formats from momentjs locales.

I have skipped the ones that uses function like https://github.com/moment/moment/blob/d0f0dd8f40be987593767a3dc5e27c45c6a3fa49/locale/he.js#L45-L50 to keep it simple

             hh : function (number) {
                if (number === 2) {
                    return 'שעתיים';
                }
                return number + ' שעות';
            }

I have also made locale tests independent, so that it tests all locales even when one of them fails, let me know if I need to revert that.

Locales with missing keys

[ 
  'ar-ly',
  'be',
  'br',
  'bs',
  'cv',
  'de-ch',
  'gl',
  'gom-latn',
  'is',
  'it-ch',
  'lb',
  'lv',
  'me',
  'mn',
  'mr',
  'sl',
  'tlh',
  'tzl'
]

[codecov-io]

Codecov Report

Merging #560 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #560   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       153    153           
  Lines       957    957           
  Branches    127    127           
===================================
  Hits        957    957

Impacted Files	Coverage Δ
src/locale/et.js	100% <ø> (ø)	⬆️
src/locale/he.js	100% <ø> (ø)	⬆️
src/locale/zh-tw.js	100% <ø> (ø)	⬆️
src/locale/zh-cn.js	100% <ø> (ø)	⬆️
src/locale/fa.js	100% <ø> (ø)	⬆️
src/locale/de.js	100% <ø> (ø)	⬆️
src/locale/sv.js	100% <ø> (ø)	⬆️
src/locale/it.js	100% <ø> (ø)	⬆️
src/locale/lt.js	100% <ø> (ø)	⬆️
src/locale/ro.js	100% <ø> (ø)	⬆️
... and 117 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 566873a...fd226f0. Read the comment docs.

[ghost]

Looks great!
I just don't know how to do this. Can you share your script to me, please?

[aadityataparia]

@xxyuk Sure: https://gist.github.com/aadityataparia/2972c69ae5a11bbbbe1f07bd69847a86

Also Tests are failing for:

1. Using ar locale to check for fallback
2. Locales which don't have all relativeTime keys (because they were functions)

[iamkun]

Perfect ~

[aadityataparia]

@iamkun Does relativeTimePlugin supports functions? if yes maybe we can import simple functions.

[iamkun]

@aadityataparia Not yet. But we could do this.

[aadityataparia]

@iamkun For now, should I remove relativeTime for locales which have function values?

[iamkun]

@iamkun For now, should I remove relativeTime for locales which have function values?

Yes, please. Still, we could add these later.

[aadityataparia]

@iamkun Done, all tests are passing now.

[iamkun]

what's this used for?

[aadityataparia]

Ah, sorry! Removing

[aadityataparia]

Also, @iamkun Any alternatives?

[iamkun]

Never mind, I'll deal with this later.

[aadityataparia]

@iamkun any timeline on when this will be merged? 🤔

[iamkun]

next release 😬

[ghost]

const fs = require('fs')
const path = require('path')

const momentLocaleFolder = path.join(__dirname, 'locale')
const dayjsLocaleFolder = path.join(__dirname, 'src/locale')
const saveFolder = path.join(__dirname, 'src/locale')
const Moment = require(path.join(__dirname, './moment'))

function objectToString(obj, prefix = '  ') {
  let string = '{'
  Object.keys(obj).forEach((p, i) => {
    const str = JSON.stringify(obj[p])
    if (str) string += `\n${prefix}${p}: ${str}${i < Object.keys(obj).length - 1 ? ',' : ''}`
  })
  string += '\n},'
  return string
}

fs.readdirSync(momentLocaleFolder).forEach((file) => {
  const filePath = path.join(momentLocaleFolder, file)
  require(filePath)
  const momentLocaleRelativeTime = Moment[file.replace('.js', '')].relativeTime
  const momentLocaleFormats = Moment[file.replace('.js', '')].longDateFormat
  delete momentLocaleRelativeTime.ss

  const dayjsFilePath = path.join(dayjsLocaleFolder, file)
  const dayjsFile = fs.readFileSync(dayjsFilePath, 'utf-8')
  const oldLocale = dayjsFile.split('const locale = ')[1].split('dayjs.locale')[0]

  let toBeAdded = ''
  if (oldLocale.indexOf('formats') < 0) {
    toBeAdded += `formats: ${objectToString(momentLocaleFormats)}\n  `
  }

  if (oldLocale.indexOf('relativeTime') < 0) {
    toBeAdded += `relativeTime: ${objectToString(momentLocaleRelativeTime)}\n  `
  }

  const start = oldLocale.substring(0, oldLocale.lastIndexOf('}'))
  const end = oldLocale.substring(oldLocale.lastIndexOf('}'), oldLocale.length)
  const localeToWrite = `${start}${toBeAdded ? ',' : ''}${toBeAdded}${end}`

  const saveLocalePath = path.join(saveFolder, file)
  fs.writeFileSync(saveLocalePath, `import dayjs from 'dayjs'
const locale = ${localeToWrite}dayjs.locale(locale, null, true)
export default locale
`)
})

// Copy momentjs locales folder to `locale` folder in dayjs root
// Create dummy `moment.js` with contents
// module.exports = {
//  defineLocale(name, val) {
//    this[name] = val
//  }
// }
// Change `saveFolder` if you want to test before overwriting original files in dayjs

aadityataparia 's solution looks great 😀

[iamkun]

🎉 This PR is included in version 1.8.13 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀