implemented isBetween inclusivity #464
Conversation
* Add Czech support
Codecov Report
@@ Coverage Diff @@
## dev #464 +/- ##
===================================
Coverage 100% 100%
===================================
Files 56 56
Lines 496 499 +3
Branches 80 81 +1
===================================
+ Hits 496 499 +3
Continue to review full report at Codecov.
|
|
Seems good |
|
@iamkun, let me know if any changes or action required from my side to merge this pull request. |
|
@waseemahmad31 Nope, all good :) |
## [1.8.6](v1.8.5...v1.8.6) (2019-02-14) ### Bug Fixes * Add Bahasa Melayu (Malaysia) locale ([#485](#485)) ([cb208b0](cb208b0)) * Copy & export built-in en locale to /locale folder as a separate file ([a7e05e0](a7e05e0)) * Fix bug in customParseFormat plugin while month(MM) is '01' ([9884ca5](9884ca5)), closes [#494](#494) * Fix commonJS require ES Module bug in webpack4 ([23f9f3d](23f9f3d)) * Fix startOf week bug while week start is not Sunday ([5eaf77b](5eaf77b)) * Implemented isBetween inclusivity ([#464](#464)) ([af2f4f1](af2f4f1)) * Update Swedish and Finnish locales ([#488](#488)) ([f142082](f142082))
|
🎉 This PR is included in version 1.8.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Surely this is one part of Moment's API that really shouldn't have been adopted? The chances of developers correctly remembering what arbitrary characters mean without referring to the documentation seem close to zero! |
This is releaded already. |
|
Yes, I'm aware that it's been released - I was just hoping to start a discussion about whether this was the right decision, and if not, whether we should propose a different API going forwards (obviously with deprecations or backwards compatibility breaks if it was in a new major version). |
## [1.8.6](iamkun/dayjs@v1.8.5...v1.8.6) (2019-02-14) ### Bug Fixes * Add Bahasa Melayu (Malaysia) locale ([#485](iamkun/dayjs#485)) ([cb208b0](iamkun/dayjs@cb208b0)) * Copy & export built-in en locale to /locale folder as a separate file ([a7e05e0](iamkun/dayjs@a7e05e0)) * Fix bug in customParseFormat plugin while month(MM) is '01' ([9884ca5](iamkun/dayjs@9884ca5)), closes [#494](iamkun/dayjs#494) * Fix commonJS require ES Module bug in webpack4 ([23f9f3d](iamkun/dayjs@23f9f3d)) * Fix startOf week bug while week start is not Sunday ([5eaf77b](iamkun/dayjs@5eaf77b)) * Implemented isBetween inclusivity ([#464](iamkun/dayjs#464)) ([af2f4f1](iamkun/dayjs@af2f4f1)) * Update Swedish and Finnish locales ([#488](iamkun/dayjs#488)) ([f142082](iamkun/dayjs@f142082))
## [1.8.6](iamkun/dayjs@v1.8.5...v1.8.6) (2019-02-14) ### Bug Fixes * Add Bahasa Melayu (Malaysia) locale ([#485](iamkun/dayjs#485)) ([cb208b0](iamkun/dayjs@cb208b0)) * Copy & export built-in en locale to /locale folder as a separate file ([a7e05e0](iamkun/dayjs@a7e05e0)) * Fix bug in customParseFormat plugin while month(MM) is '01' ([9884ca5](iamkun/dayjs@9884ca5)), closes [#494](iamkun/dayjs#494) * Fix commonJS require ES Module bug in webpack4 ([23f9f3d](iamkun/dayjs@23f9f3d)) * Fix startOf week bug while week start is not Sunday ([5eaf77b](iamkun/dayjs@5eaf77b)) * Implemented isBetween inclusivity ([#464](iamkun/dayjs#464)) ([af2f4f1](iamkun/dayjs@af2f4f1)) * Update Swedish and Finnish locales ([#488](iamkun/dayjs#488)) ([f142082](iamkun/dayjs@f142082))
This pull request will fix issue #429 and #385
Implemented inclusivity option for isBetween function