Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve locale "zh-hk" #2419

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

myleshk
Copy link
Contributor

@myleshk myleshk commented Aug 21, 2023

@iamkun
Copy link
Owner

iamkun commented Aug 24, 2023

image Thanks, can you please fix the lint error

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 95.68% and project coverage change: -0.23% ⚠️

Comparison is base (df49762) 100.00% compared to head (c45ea5b) 99.77%.
Report is 36 commits behind head on dev.

❗ Current head c45ea5b differs from pull request most recent head c8d212a. Consider uploading reports for the commit c8d212a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##               dev    #2419      +/-   ##
===========================================
- Coverage   100.00%   99.77%   -0.23%     
===========================================
  Files          183      183              
  Lines         2111     2214     +103     
  Branches       555      598      +43     
===========================================
+ Hits          2111     2209      +98     
- Misses           0        5       +5     
Files Changed Coverage Δ
src/locale/zh-hk.js 76.19% <61.53%> (-23.81%) ⬇️
src/index.js 100.00% <100.00%> (ø)
src/plugin/duration/index.js 100.00% <100.00%> (ø)
src/plugin/minMax/index.js 100.00% <100.00%> (ø)
src/plugin/objectSupport/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamkun
Copy link
Owner

iamkun commented Sep 19, 2023

can you please add some test cases to fix the codecov CI error?

@iamkun iamkun merged commit a947a51 into iamkun:dev Sep 21, 2023
4 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 28, 2024
## [1.11.11](v1.11.10...v1.11.11) (2024-04-28)

### Bug Fixes

* day of week type literal ([#2630](#2630)) ([f68d73e](f68d73e))
* improve locale "zh-hk" format and meridiem ([#2419](#2419)) ([a947a51](a947a51))
* Update 'da' locale to match correct first week of year ([#2592](#2592)) ([44b0936](44b0936))
* update locale Bulgarian monthsShort Jan ([#2538](#2538)) ([f0c9a41](f0c9a41))
Copy link

🎉 This PR is included in version 1.11.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants