fix: Locale: bo [Tibetan]: corrected the orders in formats #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, dayjs is great. I have used it in my recent project. Thanks. But there is some formats which are incorrect in Tibetan. like, In Tibetan its, ལོ་ 6 (means 6 years) rather than 6 ལོ ( which sounds like years 6 in English ). Here are some correct formats that we are able to do. Thanks again! Cheers! :)
KalDhondup
changed the title
|
LGTM. @KalDhondup would you please ask a native speaker to review this PR before it gets merged? Thanks |
fixes after review from a native speaker
Codecov Report
@@ Coverage Diff @@
## dev #1823 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 180 180
Lines 2034 2034
Branches 524 524
=========================================
Hits 2034 2034
Continue to review full report at Codecov.
|
KalDhondup
commented
Mar 17, 2022
|
Hi @iamkun, Thanks. We discussed with a native speaker and he did some more corrections. It's thoroughly reviewed. |
KalDhondup
added a commit
to KalDhondup/dayjs
that referenced
this pull request
Mar 22, 2022
Hi @iamkun, These changes are reviewed with help Tibetan native speaker. There is some issue with previous pull request(iamkun#1823) and we are making a new pull request. Thanks :)
Closed
|
Hi, please fix the lint error before the PR get merged |
fixing lint error.
|
Hi @iamkun, The issue is fixed. Its good to go 👍 |
iamkun
pushed a commit
that referenced
this pull request
Apr 15, 2022
## [1.11.1](v1.11.0...v1.11.1) (2022-04-15) ### Bug Fixes * add Bengali (Bangladesh) [bn-bd] locale ([#1806](#1806)) ([840ed76](840ed76)) * refactor replace deprecated String.prototype.substr() ([#1836](#1836)) ([627fa39](627fa39)) * Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](#1831)) ([4e2802c](4e2802c)) * update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](#1829)) ([8e6d11d](8e6d11d)) * update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](#1848)) ([a597d0b](a597d0b)) * update locale bo [Tibetan]: corrected the orders in formats ([#1823](#1823)) ([e790516](e790516))
|
🎉 This PR is included in version 1.11.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15) ### Bug Fixes * add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76)) * refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39)) * Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c)) * update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d)) * update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b)) * update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
andrewhood125ruhuc
added a commit
to andrewhood125ruhuc/SidRH2
that referenced
this pull request
May 10, 2022
## [1.11.1](iamkun/dayjs@v1.11.0...v1.11.1) (2022-04-15) ### Bug Fixes * add Bengali (Bangladesh) [bn-bd] locale ([#1806](iamkun/dayjs#1806)) ([840ed76](iamkun/dayjs@840ed76)) * refactor replace deprecated String.prototype.substr() ([#1836](iamkun/dayjs#1836)) ([627fa39](iamkun/dayjs@627fa39)) * Update German [de] locale, adds the abbreviations for month including a . in the end, as in September -> Sept. ([#1831](iamkun/dayjs#1831)) ([4e2802c](iamkun/dayjs@4e2802c)) * update Italian (Switzerland) [it-ch] locale relativeTime ([#1829](iamkun/dayjs#1829)) ([8e6d11d](iamkun/dayjs@8e6d11d)) * update Kurdish [ku] locale strings and formatted output contains non-standard kurdish characters ([#1848](iamkun/dayjs#1848)) ([a597d0b](iamkun/dayjs@a597d0b)) * update locale bo [Tibetan]: corrected the orders in formats ([#1823](iamkun/dayjs#1823)) ([e790516](iamkun/dayjs@e790516))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, dayjs is great. I have used it in my recent project. Thanks. But there is some formats which are incorrect in Tibetan.
like, In Tibetan its, ལོ་ 6 (means 6 years) rather than 6 ལོ ( which sounds like years 6 in English ).
Here are some correct formats that we are able to do. Thanks again! Cheers! :)